This repository was archived by the owner on Mar 11, 2025. It is now read-only.
stake-pool-js: export the StakePoolLayout #7324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
reviewed
Oct 7, 2024
Contributor
buffalojoec
left a comment
buffalojoec
left a comment
There was a problem hiding this comment.
Wfm. Any opposition to making the layouts public here @joncinque ?
stake-pool/js/src/index.ts
Outdated
| export type { StakePool, AccountType, ValidatorList, ValidatorStakeInfo } from './layouts'; | ||
| export { STAKE_POOL_PROGRAM_ID } from './constants'; | ||
| export * from './instructions'; | ||
| export { StakePoolLayout } from './layouts'; |
Contributor
There was a problem hiding this comment.
If we're going to make this one public, might as well do ValidatorStakeInfoLayout and ValidatorListLayout as well.
joncinque
previously approved these changes
Oct 8, 2024
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks good to me (with Joe's question)!
mergify
bot
dismissed
joncinque’s stale review
Pull request has been modified.
joncinque
approved these changes
Oct 8, 2024
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Contributor
|
Merging early since the stake pool tests passed |
joncinque
changed the title
joncinque
added a commit
to joncinque/solana-program-library
that referenced
this pull request
Oct 8, 2024
#### Problem solana-labs#7324 exposed some needed types, but it's not released yet. #### Summary of changes Bump the patch version to release a new version.
joncinque
added a commit
that referenced
this pull request
Oct 8, 2024
#### Problem #7324 exposed some needed types, but it's not released yet. #### Summary of changes Bump the patch version to release a new version.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary to load individual StakePools by their pubkey (possibly across different stake pool program deployments) and decode.